I think it is easier to do the embroidery on each block and any embroidery across seam lines after the blocks are joined. The blocks are much easier to handle when they are small units.
According to the link, it says that there is no right or wrong:
http://www.needlework-tips-and-techn...mbroidery.html