I always use a magnetic snap which I attach to the lining before sewing the outer bag to the lining. I use a small piece of cardboard or vinyl on the wrong side of the lining before I turn the prongs of the snap down. It helps prevent any wear on the lining as the snap is used.
I use good quality quilters' cotton; this bag looks great in batiks.
Have fun making them!