I store like with like in the biggest (yet smallest) box that will hold them. I think my threads are in 4 shoe boxes by color family. Safety pins are in clear jars and straight pins are in another clear jar.
I think it's trial and error and continually changing because our notions continue to grow.