I depends. I do both. It often depends on how much fabric I have for the outer border. I like to make 8-10" borders which takes a lot of fabric to do the diagonal. If I have the fabric then I will do diagioal but if not then I do staight. My eperience has been that it really does not make much diffrence. For inner borders that are smaller then I do diagonal piecing.