I am like the other posters, I will only buy a presser foot that is made by my machine manufacturer (or made under license for them).
That said ...
Overall, yes - metal feet can last longer than plastic feet. The plastic can be damaged easier than the metal. I've put a needle through one of my plastic feet. They can get gouged and scraped leaving ragged edges that can snag fabric.
There are times though when plastic feet are either necessary or more desirable. Vision is one reason, the other is that the plastic feet have red markings on them making it easier to see the markings - most metal feet that have "markings" are just grooves in the metal and not real easy to see in certain lighting. If you need to rely on the marking on a foot then I prefer plastic.
If vision wasn't a factor, and I didn't need the markings on the foot then I would choose a metal foot. But as I said, I don't buy "generic" feet. A presser foot will last me a LOOOOOONG time, so it's worth it to me to buy the correct foot.