All sorts of different options work for different people. I keep my scraps in plastic shoe boxes, sorted by color or fabric type (novelty, batik, etc.) I like to keep them ironed flat, rather than jumbled in a hamper, and I have shelves in the sewing room where the boxes are stacked and labeled, so I can find them easily. This works better for me.