I think it depends on what you stuff it with. Some people (not me) use ground walnut shells inside their pincushions and they make a fabric bag for the walnut shells to put inside the decorative pincushion cover. I am told the the ground walnut shells sharpen the pins.
I've used wool batting as stuffing for the few that I've made, and I didn't use an inside bag.